build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63364 )
Change subject: soc/intel/meteorlake/ramstage: Do initial SoC commit till ramstage ......................................................................
Patch Set 1:
(28 comments)
File src/soc/intel/meteorlake/acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/b33934e4_4a344ee1 PS1, Line 180: printk(BIOS_DEBUG, "%s - gfxvtbar:0x%llx 0x%x \n", __func__, gfxvtbar, MCHBAR32(GFXVTBAR)); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/80cb67d1_1f344d43 PS1, Line 180: printk(BIOS_DEBUG, "%s - gfxvtbar:0x%llx 0x%x \n", __func__, gfxvtbar, MCHBAR32(GFXVTBAR)); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/04e98d27_6218462b PS1, Line 201: if (is_dev_enabled(igfx_dev) && gfxvtbar && gfxvten ) { space prohibited before that close parenthesis ')'
File src/soc/intel/meteorlake/cpu.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/9503557f_3559db9a PS1, Line 28: if (!CONFIG(X2APIC_ONLY)) { braces {} are not necessary for single statement blocks
File src/soc/intel/meteorlake/fsp_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/299b5312_ee180f24 PS1, Line 352: if (CONFIG(SOC_INTEL_CSE_LITE_SKU) && cse_is_hfs3_fw_sku_lite() code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/2693f0fe_ebd51f80 PS1, Line 352: if (CONFIG(SOC_INTEL_CSE_LITE_SKU) && cse_is_hfs3_fw_sku_lite() please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/2bc2821c_fe46da3b PS1, Line 353: && vboot_recovery_mode_enabled() && !cse_is_hfs1_com_normal()) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/5e35f550_c887a98e PS1, Line 353: && vboot_recovery_mode_enabled() && !cse_is_hfs1_com_normal()) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/5a874e50_7d380c76 PS1, Line 354: /* code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/2f63dfa5_6af854e1 PS1, Line 355: * CSE Lite SKU does not support hybrid storage dynamic configuration code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/a6b62b09_b0a0982f PS1, Line 356: * in CSE RO boot, and FSP does not allow to send the strap override code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/68a07d9a_95a5b3c7 PS1, Line 357: * HECI commands if CSE is not in normal mode; hence, hybrid storage code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/057baab8_546dae74 PS1, Line 358: * mode is disabled on CSE RO boot in recovery boot mode. code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/4ee4e08c_174bd927 PS1, Line 359: */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/a2b0d9af_ae09accc PS1, Line 360: printk(BIOS_INFO, "cse_lite: CSE RO boot. HybridStorageMode disabled\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/5003036f_8a95fb90 PS1, Line 360: printk(BIOS_INFO, "cse_lite: CSE RO boot. HybridStorageMode disabled\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/aced5099_0c7ec565 PS1, Line 361: s_cfg->HybridStorageMode = 0; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/0b19889a_9c5978ed PS1, Line 361: s_cfg->HybridStorageMode = 0; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/c53f8736_5d710781 PS1, Line 362: } else { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/da635127_01fee6eb PS1, Line 362: } else { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/e0855bd5_a71fab39 PS1, Line 363: s_cfg->HybridStorageMode = config->HybridStorageMode; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/ee386535_8de75e2c PS1, Line 363: s_cfg->HybridStorageMode = config->HybridStorageMode; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/10ed7677_ab238614 PS1, Line 364: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/4f75871f_72ce320f PS1, Line 364: } please, no spaces at the start of a line
File src/soc/intel/meteorlake/pmc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/2d3711b7_1e4a1d3c PS1, Line 122: if (CONFIG(SOC_INTEL_COMMON_BLOCK_ACPI_PEP)) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/014e218e_f394a041 PS1, Line 122: if (CONFIG(SOC_INTEL_COMMON_BLOCK_ACPI_PEP)) { suspect code indent for conditional statements (4, 16)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/30fdd874_8ed9f8fb PS1, Line 122: if (CONFIG(SOC_INTEL_COMMON_BLOCK_ACPI_PEP)) { suspicious code indentation after conditional statements
File src/soc/intel/meteorlake/soc_info.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145362): https://review.coreboot.org/c/coreboot/+/63364/comment/3a8fe15d_ada63169 PS1, Line 26: return MTLP; trailing whitespace