[coreboot-gerrit] Patch set updated for coreboot: f1d1966 ARM: when setting a GPIO to put, set the value, then the direction

[Gabe Black]

Gabe Black ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3679

-gerrit

commit f1d196675ec759cab4a277ef090611a4648be145
Author: Ronald G. Minnich 
Date:   Tue Jun 18 13:02:23 2013 -0700

ARM: when setting a GPIO to put, set the value, then the direction

We saw a problem on x86 last year in which setting direction, then value,
    glitched the output and caused problems. Change this code to set the output,
    then the direction.

Change-Id: I3e1e17ffe82ae270eea539530368a58c6cfe0ebe
    Signed-off-by: Ronald G. Minnich 
    Signed-off-by: Gabe Black 
---
 src/cpu/samsung/exynos5250/gpio.c | 4 ++--
 src/cpu/samsung/exynos5420/gpio.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/cpu/samsung/exynos5250/gpio.c b/src/cpu/samsung/exynos5250/gpio.c
index b8ebb0a..2a93328 100644
--- a/src/cpu/samsung/exynos5250/gpio.c
+++ b/src/cpu/samsung/exynos5250/gpio.c
@@ -170,14 +170,14 @@ int gpio_direction_output(unsigned gpio, int value)
    unsigned int val;
    struct gpio_bank *bank = gpio_get_bank(gpio);

-	gpio_cfg_pin(gpio, GPIO_OUTPUT);
-
    val = readl(&bank->dat);
    val &= ~DAT_MASK(GPIO_BIT(gpio));
    if (value)
    	val |= DAT_SET(GPIO_BIT(gpio));
    writel(val, &bank->dat);

+	gpio_cfg_pin(gpio, GPIO_OUTPUT);
+
    return 0;
 }

diff --git a/src/cpu/samsung/exynos5420/gpio.c b/src/cpu/samsung/exynos5420/gpio.c
index b8ebb0a..2a93328 100644
--- a/src/cpu/samsung/exynos5420/gpio.c
+++ b/src/cpu/samsung/exynos5420/gpio.c
@@ -170,14 +170,14 @@ int gpio_direction_output(unsigned gpio, int value)
    unsigned int val;
    struct gpio_bank *bank = gpio_get_bank(gpio);

-	gpio_cfg_pin(gpio, GPIO_OUTPUT);
-
    val = readl(&bank->dat);
    val &= ~DAT_MASK(GPIO_BIT(gpio));
    if (value)
    	val |= DAT_SET(GPIO_BIT(gpio));
    writel(val, &bank->dat);

+	gpio_cfg_pin(gpio, GPIO_OUTPUT);
+
    return 0;
 }