3 Jun
2019
3 Jun
'19
6:10 p.m.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33115 )
Change subject: Makefile.inc: Compile smm files based on CONFIG_BUILD_SMM ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/33115/5/src/arch/x86/Makefile.inc File src/arch/x86/Makefile.inc:
https://review.coreboot.org/#/c/33115/5/src/arch/x86/Makefile.inc@403 PS5, Line 403: CONFIG_BUILD_SMM
I don't think this guard is needed here. […]
Same thing as all my other comments. We need to determine what is pulling in the dependencies such that these rules are being evaluated.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33115
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17a3eb80a4d5ef86e0319357c01b6bf5b90ef15b
Gerrit-Change-Number: 33115
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 03 Jun 2019 16:10:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org
Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com
Gerrit-MessageType: comment