build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39847 )
Change subject: soc/intel/tigerlake: Add support to initialize Memory ......................................................................
Patch Set 17:
(10 comments)
https://review.coreboot.org/c/coreboot/+/39847/17/src/soc/intel/tigerlake/me... File src/soc/intel/tigerlake/meminit_tgl.c:
https://review.coreboot.org/c/coreboot/+/39847/17/src/soc/intel/tigerlake/me... PS17, Line 320: else else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/39847/17/src/soc/intel/tigerlake/me... PS17, Line 321: printk(BIOS_INFO,"Undefined memory topology on Channel 0"); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39847/17/src/soc/intel/tigerlake/me... PS17, Line 329: else if ((info->topology == MEMORY_DOWN)) { Unnecessary parentheses - maybe == should be = ?
https://review.coreboot.org/c/coreboot/+/39847/17/src/soc/intel/tigerlake/me... PS17, Line 333: else if ((info->topology == SODIMM) || (info->topology == MIXED)) { else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/39847/17/src/soc/intel/tigerlake/me... PS17, Line 337: else else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/39847/17/src/soc/intel/tigerlake/me... PS17, Line 338: printk(BIOS_DEBUG,"Undefined memory topology on channel 1"); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39847/17/src/soc/intel/tigerlake/me... PS17, Line 340: else else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/39847/17/src/soc/intel/tigerlake/me... PS17, Line 341: printk(BIOS_DEBUG,"Unsupported channels"); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39847/17/src/soc/intel/tigerlake/me... PS17, Line 367: if ((info->topology == MIXED) && (mem_cfg->MemorySpdDataLen != spd_sodimm_blk.len)) line over 96 characters
https://review.coreboot.org/c/coreboot/+/39847/17/src/soc/intel/tigerlake/me... PS17, Line 416: else { else should follow close brace '}'