Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42523 )
Change subject: soc/amd/common,picasso: Place some ENV_X86 guards ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42523/7/src/soc/amd/common/block/ac... File src/soc/amd/common/block/acpimmio/mmio_util.c:
https://review.coreboot.org/c/coreboot/+/42523/7/src/soc/amd/common/block/ac... PS7, Line 32: DECLARE_ACPIMMIO_BANK
No reason to use DECLARE_ACPIMMIO_BANK in this block.
In the lack of psp-verstage, I had experimented with the combination of ENV_X86 && !CONSTANT_ACPIMMIO_BASE_ADDRESS to see possible impacts on code size and aliasing MMIO writes.
Without const qualifier I would need to drop value assignment, else it needs .data section. So MAYBE_CONST alone is not a solution here either.
If new mappings appear to PSP servicecalls we would need to add these back one-by-one.
https://review.coreboot.org/c/coreboot/+/42523/7/src/soc/amd/common/block/ac... File src/soc/amd/common/block/acpimmio/psp_verstage_stub.c:
PS7:
I would just remove these since we can directly set acpimmio_iomux from psp_verstage.
It was just a stub anyways. Seemed like psp_verstage is architected such that a static function needs to be added for simple variable assignments.