Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47990 )
Change subject: soc/intel/common/fast_spi: Add extended decode window support ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47990/4/src/soc/intel/common/block/... File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/47990/4/src/soc/intel/common/block/... PS4, Line 327: fast_spi_enable_ext_bios
This will have to be done outside of MMIO space enabling. […]
Actually, GPMR will be programmed before disabling PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY so that if GPMR programming fails, we don't have to touch any fast spi configs at all.