Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44695 )
Change subject: superio/winbond/wpcd376i: Resurrect the driver
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44695/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44695/2//COMMIT_MSG@12
PS2, Line 12: Replacing
I don't agree. I believe the grammar is correct here (and in the rest of the sentence).
With the preceding sentence “Changes from the previous version include:” using the gerund for the changes can be used.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44695
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ff1a63c47d5dff2599c83a1cebe1ac5ff2136b1
Gerrit-Change-Number: 44695
Gerrit-PatchSet: 2
Gerrit-Owner: Samuel Holland
samuel@sholland.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 26 Aug 2020 07:51:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Samuel Holland
samuel@sholland.org
Gerrit-MessageType: comment