Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40393 )
Change subject: mb/google/hatch: Add Kaisa variant ......................................................................
Patch Set 4:
(3 comments)
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40393/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/40393/2/src/mainboard/google/hatch/... PS2, Line 109: default "Kaisa" if BOARD_GOOGLE_KAISA
alphabetize in the list of variants.
Done
https://review.coreboot.org/c/coreboot/+/40393/2/src/mainboard/google/hatch/... PS2, Line 137: default "kaisa" if BOARD_GOOGLE_KAISA
alphabetize in the list of variants.
Done
https://review.coreboot.org/c/coreboot/+/40393/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/40393/2/src/mainboard/google/hatch/... PS2, Line 85: config BOARD_GOOGLE_KAISA
alphabetize in the list of variants.
I somehow lost that fix locally before the push weird, anyway redone again.