Attention is currently required from: Jianjun Wang. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56794 )
Change subject: libpayload/pci: Add PCIe interfaces for MediaTek platform ......................................................................
Patch Set 3:
(2 comments)
File payloads/libpayload/drivers/pcie_mediatek.c:
https://review.coreboot.org/c/coreboot/+/56794/comment/3f950ad2_e08d8b9e PS3, Line 34: PCIE_CFG_FORCE_BYTE_EN | PCIE_CFG_BYTE_EN(bytes) Ah, if I understand correctly, this avoids clearing the wrong bytes when doing 8-bit or 16-bit writes.
https://review.coreboot.org/c/coreboot/+/56794/comment/9c9de724_80704f67 PS3, Line 50: ((1 << (size * 8)) - 1) This mask shouldn't be necessary, as the return type of the `pci_read_configX()` functions already truncates the value accordingly.