Attention is currently required from: Shelley Chen. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45206 )
Change subject: herobrine: sc7280: Provide initial mainboard support ......................................................................
Patch Set 24:
(4 comments)
File payloads/libpayload/drivers/serial/sc7280.c:
https://review.coreboot.org/c/coreboot/+/45206/comment/f7daccc1_074881e2 PS24, Line 5: /* For simplicity sake let's rely on coreboot initalizing the UART. */ 'initalizing' may be misspelled - perhaps 'initializing'?
File src/mainboard/google/herobrine/boardid.c:
https://review.coreboot.org/c/coreboot/+/45206/comment/5809bbd7_920071de PS24, Line 9: trailing whitespace
https://review.coreboot.org/c/coreboot/+/45206/comment/1a6a6e0a_135ff82e PS24, Line 16: trailing whitespace
https://review.coreboot.org/c/coreboot/+/45206/comment/973007d4_7867c5ad PS24, Line 23: trailing whitespace