Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33772 )
Change subject: mb/amd/mandolin: Add Picasso CRB ......................................................................
Patch Set 43:
(8 comments)
https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... File src/mainboard/amd/mandolin/acpi/gpe.asl:
https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... PS42, Line 34: I don't think we have any of these method on zork. Do we need them?
https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... File src/mainboard/amd/mandolin/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... PS42, Line 5: cim_verb_data Whats all this do?
https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... File src/mainboard/amd/mandolin/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... PS42, Line 28: write_pirq_routing_table wow, this method is complicated...
https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... PS42, Line 56: 0x1002 Can you use the ids from pci_ids.h?
https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... PS42, Line 68: 0xdef8 What is this bitmap format?
https://review.coreboot.org/c/coreboot/+/33772/43/src/mainboard/amd/mandolin... File src/mainboard/amd/mandolin/mainboard.c:
https://review.coreboot.org/c/coreboot/+/33772/43/src/mainboard/amd/mandolin... PS43, Line 88: 0 0 or NC?
https://review.coreboot.org/c/coreboot/+/33772/43/src/mainboard/amd/mandolin... PS43, Line 108: 0 NC?
https://review.coreboot.org/c/coreboot/+/33772/43/src/mainboard/amd/mandolin... File src/mainboard/amd/mandolin/mptable.c:
PS43: Do we care about mp tables anymore? We deleted them for zork.