build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31205 )
Change subject: [RFC] Initial commit to support SKL SP and OCP Tiogapass platform ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31205/1/src/mainboard/ocp/tiogapass/gpio.h File src/mainboard/ocp/tiogapass/gpio.h:
https://review.coreboot.org/#/c/31205/1/src/mainboard/ocp/tiogapass/gpio.h@1... PS1, Line 110: /* SATAXPCIE_4 */ PAD_CFG_NF(GPP_F1, 20K_PU, DEEP,NF1), space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/31205/1/src/soc/intel/skylake/romstage/romst... File src/soc/intel/skylake/romstage/romstage_fsp20.c:
https://review.coreboot.org/#/c/31205/1/src/soc/intel/skylake/romstage/romst... PS1, Line 106: switch(memory_info_hob->MemoryType) { space required before the open parenthesis '('