build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32363 )
Change subject: /mainboard/pcengines/apu2: implement POSTCAR_STAGE ......................................................................
Patch Set 1:
(8 comments)
https://review.coreboot.org/#/c/32363/1/src/mainboard/pcengines/apu2/BiosCal... File src/mainboard/pcengines/apu2/BiosCallOuts.c:
https://review.coreboot.org/#/c/32363/1/src/mainboard/pcengines/apu2/BiosCal... PS1, Line 100: FchParams->Sata.SataDevSlpPort0 = 0; // Disable DEVSLP0 and 1 to make sure GPIO55 and 59 are not used by DEVSLP line over 80 characters
https://review.coreboot.org/#/c/32363/1/src/mainboard/pcengines/apu2/state_m... File src/mainboard/pcengines/apu2/state_machine.c:
https://review.coreboot.org/#/c/32363/1/src/mainboard/pcengines/apu2/state_m... PS1, Line 81: AmdGetValue ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/32363/1/src/mainboard/pcengines/apu2/state_m... PS1, Line 82: IN CONST AGESA_FIELD_NAME name, please, no spaces at the start of a line
https://review.coreboot.org/#/c/32363/1/src/mainboard/pcengines/apu2/state_m... PS1, Line 83: IN OUT VOID** value, please, no spaces at the start of a line
https://review.coreboot.org/#/c/32363/1/src/mainboard/pcengines/apu2/state_m... PS1, Line 83: IN OUT VOID** value, space prohibited after that '*' (ctx:OxW)
https://review.coreboot.org/#/c/32363/1/src/mainboard/pcengines/apu2/state_m... PS1, Line 84: IN UINT32 size please, no spaces at the start of a line
https://review.coreboot.org/#/c/32363/1/src/mainboard/pcengines/apu2/state_m... PS1, Line 85: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/32363/1/src/mainboard/pcengines/apu2/state_m... PS1, Line 99: status = module_dispatch(AMD_GET_VALUE, (AMD_CONFIG_PARAMS*) &Params); "(foo*)" should be "(foo *)"