Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42790 )
Change subject: soc/intel/tigerlake: Switch to CSE Lite RW at BS_DEV_INIT_CHIPS entry
......................................................................
Patch Set 5:
(1 comment)
Patch Set 5: -Code-Review
Ok, I had missed some of the background here. Thank for your analysis Rizwan. A straight-up revert when this is not needed would be great.
Yes, we can just revert when 159884143 is fixed
https://review.coreboot.org/c/coreboot/+/42790/5/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/42790/5/src/soc/intel/common/block/...
PS5, Line 364: #if CONFIG(SOC_INTEL_TIGERLAKE)
: BOOT_STATE_INIT_ENTRY(BS_DEV_INIT_CHIPS, BS_ON_ENTRY, cse_fw_sync, NULL);
: #else
Although mute, please add a TODO to indicate that this should be removed once the issue is fixed in the CSE firmware i.e when we have a true fix for b:159884143
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42790
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib136a2154b36c63c7147bbcfbf1ca7beac3a5685
Gerrit-Change-Number: 42790
Gerrit-PatchSet: 5
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Tue, 30 Jun 2020 18:53:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment