Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37996 )
Change subject: soc/mediatek/mt8183: do TX tracking for DRAM DVFS feature ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37996/9/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/37996/9/src/soc/mediatek/mt8183/dra... PS9, Line 2139: while (!wait_us(10, read32(&ch[chn].nao.spcmdresp) & (0x1 << 10))) {
I think Paul means the wait_us() macro. […]
Sorry for the late replay. Please search for `stopwatch_init_msecs_expire()` and `stopwatch_expired()` in the coreboot code.
https://review.coreboot.org/cgit/coreboot.git/tree/src/include/timer.h#n162
https://review.coreboot.org/c/coreboot/+/37996/9/src/soc/mediatek/mt8183/dra... PS9, Line 2150: u8 mr23 = 0x3F;
is a default value. […]
Add that as a comment?
https://review.coreboot.org/c/coreboot/+/37996/9/src/soc/mediatek/mt8183/dra... PS9, Line 2251: u8 mr23 = 0x3F;
Since this value appears more than once, we should define a constant for it. Something like: […]
Good idea.