[coreboot-gerrit] [S] Change in coreboot[master]: soc/intel/alderlake: Hook up PchHdaAudioLinkHdaEnable to devicetree

[Maximilian Brune (Code Review)]

Attention is currently required from: Sean Rhodes, Nico Huber, Tarun Tuli, Michał Żygowski, Subrata Banik, Paul Menzel, Arthur Heymans, Eric Lai.

Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71715 )

Change subject: soc/intel/alderlake: Hook up PchHdaAudioLinkHdaEnable to devicetree
......................................................................

Patch Set 4:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/71715/comment/fdc476b2_d7fc27b2 
PS3, Line 15:
> They dropped one UPD more than needed.
> PchHdaAudioLink{Hda|Dmic|Ssp|Sndw} are responsible for GPIO configuration but PchHdaAudioLinkHda additionally controls if HDA SDI pins are enabled or disabled via sideband PCR register. HDA GPIOs are not touched because coreboot sets GpioOverride to 1.

Like Paul said, it would be nice to have this information in the commit msg. Maybe even as code comment/doc.

Furthermore I thought that SDI pins are enabled/disabled via:
    PchHdaSdiEnable[0] = 1;
    PchHdaSdiEnable[1] = 1;