Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36273 )
Change subject: lib/cbmem_top: Add a common cbmem_top implementation ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36273/1/src/include/cbmem.h File src/include/cbmem.h:
https://review.coreboot.org/c/coreboot/+/36273/1/src/include/cbmem.h@77 PS1, Line 77: uintptr_t
uintptr_t may not match between stages unless we're asserting that's always the case.
Ok I'll add checks. I think it is a reasonable thing to expect?
https://review.coreboot.org/c/coreboot/+/36273/1/src/include/cbmem.h@79 PS1, Line 79: void *cbmem_top_romstage(void);
You should add some commentary on these new functions/objects and their semantics.
ok