Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41884 )
Change subject: drivers/intel/dptf: Add current participant Devices to DSDT ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41884/10/src/drivers/intel/dptf/dpt... File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/41884/10/src/drivers/intel/dptf/dpt... PS10, Line 95: /* The CPU device gets an _ADR that matches the ACPI PCI address for 00:04.00 */ : parent = dev && dev->bus ? dev->bus->dev : NULL; : if (!parent || parent->path.type != DEVICE_PATH_PCI) { : printk(BIOS_ERR, "%s: DPTF objects must live under 00:04.0 PCI device\n", : __func__); : return; : } acpigen_write_ADR_pci_device asserts that the device is of type PCI. Is this check to avoid that?
https://review.coreboot.org/c/coreboot/+/41884/10/src/drivers/intel/dptf/dpt... PS10, Line 125: acpigen_write_device("TFN1"); It is required only if active cooling is desired. I haven't seen a use case of small-core platforms employing active cooling. Small core platforms use passive cooling only. Do we want to make it configurable?