build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33400 )
Change subject: util/amdfwtool: Update for Family 17h ......................................................................
Patch Set 2:
(11 comments)
https://review.coreboot.org/#/c/33400/2/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/#/c/33400/2/util/amdfwtool/amdfwtool.c@202 PS2, Line 202: printf("-U | --token-unlock Reserve space for debug token\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/2/util/amdfwtool/amdfwtool.c@207 PS2, Line 207: printf("-I | --instance <number> Sets instance field for the next BIOS firmware\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/2/util/amdfwtool/amdfwtool.c@208 PS2, Line 208: printf("-a | --apcb <FILE> Add AGESA PSP customization block\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/2/util/amdfwtool/amdfwtool.c@209 PS2, Line 209: printf("-Q | --apob-base <HEX_VAL> Destination for AGESA PSP output block\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/2/util/amdfwtool/amdfwtool.c@212 PS2, Line 212: printf("-y | --pmu-inst <FILE> Add PMU firmware instruction portion\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/2/util/amdfwtool/amdfwtool.c@213 PS2, Line 213: printf("-G | --pmu-data <FILE> Add PMU firmware data portion\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/2/util/amdfwtool/amdfwtool.c@216 PS2, Line 216: printf("-V | --bios-bin <FILE> Add compressed image; auto source address\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/2/util/amdfwtool/amdfwtool.c@217 PS2, Line 217: printf("-e | --bios-bin-src <HEX_VAL> Address in flash of source if -V not used\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/2/util/amdfwtool/amdfwtool.c@218 PS2, Line 218: printf("-v | --bios-bin-dest <HEX_VAL> Destination for uncompressed BIOS\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/2/util/amdfwtool/amdfwtool.c@219 PS2, Line 219: printf("-j | --bios-uncomp-size <HEX> Uncompressed size of BIOS image\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/2/util/amdfwtool/amdfwtool.c@964 PS2, Line 964: static const char *optstring = "x:i:g:AMS:p:b:s:r:k:c:n:d:t:u:w:m:T:z:J:B:K:L:Y:N:UW:I:a:Q:V:e:v:j:y:G:O:X:F:H:o:f:l:h"; line over 80 characters