Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41443 )
Change subject: device: Add support for resource allocator v4 ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41443/6/src/device/resource_allocat... File src/device/resource_allocator_v4.c:
https://review.coreboot.org/c/coreboot/+/41443/6/src/device/resource_allocat... PS6, Line 249: res->flags |= IORESOURCE_ASSIGNED; This doesn't seem like a good idea, and I don't understand the reason behind it. Any `.set_resources` would have to check if `base + size - 1 <= limit` before it writes "assigned" resources. IMHO, we should only set IORESOURCE_ASSIGNED if the resource is valid.
https://review.coreboot.org/c/coreboot/+/41443/6/src/device/resource_allocat... PS6, Line 261: find_pci_tolm() Why start a new allocator with a quirk? It seems easy to ignore unassigned resources in find_pci_tolm().