Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35853 )
Change subject: src/southbridge/amd/pi/hudson/Makefile.inc: fix AMDFW outside CBFS ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35853/1/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35853/1/src/southbridge/amd/pi/huds... PS1, Line 76: HUDSON_FWM_POSITION=$(call int-add, $(call int-subtract, 0xffffffff $(CONFIG_ROM_SIZE)) 0x20000 1)
I used the same approach as stoneyridge
I'd prefer if HUDSON_FWM_POSITION already contains the prefix; this would also make this case consistent with the other one where the 0x prefix is present. Having this inconsistent here and doing the fixup 100 lines later is also not too obvious