Attention is currently required from: Tim Wawrzynczak, Zhuohao Lee, Curtis Chen.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57490 )
Change subject: mb/google/volteer: Create APIs for USB-C DP alternate mode support
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/57490/comment/a9969dcc_ae527639
PS5, Line 9: #include <ec/google/chromeec/chip.h>
Is this required?
No. Removed it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57490
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If73e0ce0154f0dc4f81dc449b7ec89316fe93814
Gerrit-Change-Number: 57490
Gerrit-PatchSet: 6
Gerrit-Owner: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 17 Sep 2021 08:49:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment