[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer: Add boldar GPIO configuration

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46131 )

Change subject: mb/google/volteer: Add boldar GPIO configuration
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46131/7/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/boldar/gpio.c:

https://review.coreboot.org/c/coreboot/+/46131/7/src/mainboard/google/voltee... 
PS7, Line 8: static const struct pad_config override_gpio_table[] = {
> yes, the differences are due to different SoC.

I think it would be good to evaluate if we should have two different baseboard gpio tables - one for each SoC type so that the variant override tables don't look so large. Also, easier to manage any quirks like we never have touched eSPI pads in coreboot (since there were some issues reconfiguring those in KBL days - not sure if those problems still exist).