Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35643 )
Change subject: util/intelp2m: add Intel Pad to Macro util
......................................................................
Patch Set 11:
Patch Set 11:
I have compared my pinconfig for x11ssm-f by converting the intelp2m output to
hex again. They mostly match. Only the pin ownership is not matching in all
Please tell me which pads are different after the patch.
I'm not sure about the PAD_CFG_GPI_INT() macro as it contains PAD_CFG1_GPIO_DRIVER.
https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/block/...
cases - I have to test the pinconfig in the next few days
Thanks for testing
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35643
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3e3b523c4f63dc2f91e9ccd16934e3a1b6e21fa
Gerrit-Change-Number: 35643
Gerrit-PatchSet: 11
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Christian Walter
christian.walter@9elements.com
Gerrit-CC: Maxim Polyakov
m.poliakov@yahoo.com
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 01 Oct 2019 15:54:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment