[coreboot-gerrit] Change in coreboot[master]: ec/google: Add RBHF, VBNL and CMPP method

[Varshit B Pandya (Code Review)]

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Rizwan Qureshi, Eric Lai.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64641 )

Change subject: ec/google: Add RBHF, VBNL and CMPP method
......................................................................

Patch Set 3:

(6 comments)

File src/ec/google/chromeec/ec_dptf_helpers.c:

https://review.coreboot.org/c/coreboot/+/64641/comment/8d79397c_d8bf8d41 
PS2, Line 213: acpigen_pop_len
> `acpigen_write_method_end()`

Done

https://review.coreboot.org/c/coreboot/+/64641/comment/0b7d980d_c10792f2 
PS2, Line 221: acpigen_write_store();
             : 	acpigen_emit_namestring(acpi_device_path_join(ec, "VBNL"));
             : 	acpigen_emit_byte(LOCAL0_OP);
             : 
             : 	/* Return (Local0) */
             : 	acpigen_emit_byte(RETURN_OP);
             : 	acpigen_emit_byte(LOCAL0_OP);
> actually can't this whole thing just be […]

Done

https://review.coreboot.org/c/coreboot/+/64641/comment/07f1a2f9_0c5fc759 
PS2, Line 226: acpigen_emit_byte(RETURN_OP);
             : 	acpigen_emit_byte(LOCAL0_OP);
> `acpigen_write_return_op(LOCAL0_OP);`

Done

https://review.coreboot.org/c/coreboot/+/64641/comment/567773a1_5e890d4d 
PS2, Line 229: acpigen_pop_len
> `acpigen_write_method_end()`

Done

https://review.coreboot.org/c/coreboot/+/64641/comment/9fcf7601_b44e4f96 
PS2, Line 237: acpigen_write_store();
             : 	acpigen_emit_namestring(acpi_device_path_join(ec, "CMPP"));
             : 	acpigen_emit_byte(LOCAL0_OP);
             : 
             : 	/* Return (Local0) */
             : 	acpigen_emit_byte(RETURN_OP);
             : 	acpigen_emit_byte(LOCAL0_OP);
> same here as above

Done

https://review.coreboot.org/c/coreboot/+/64641/comment/80f4f3d7_b69c8b78 
PS2, Line 245: acpigen_pop_len
> `acpigen_write_method_end()`

Done