Attention is currently required from: Varshit B Pandya, Francois Toguo Fotso, Sridhar Siricilla, Subrata Banik.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49871 )
Change subject: mb/intel/adlrvp_m: Add initial code for adl-m variant board
......................................................................
Patch Set 20:
(3 comments)
File src/mainboard/intel/adlrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/49871/comment/9a481c13_f5465901
PS12, Line 58: BOARD_INTEL_ADLRVP_M
|| BOARD_INTEL_ADLRVP_M_EXT_EC
Done
https://review.coreboot.org/c/coreboot/+/49871/comment/0be9dbb6_677a688a
PS12, Line 59: default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb" if BOARD_INTEL_ADLRVP_M_EXT_EC
remove this line?
Done
File src/mainboard/intel/adlrvp/variants/adlrvp_m_ext_ec/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/49871/comment/0547e052_613ab122
PS12, Line 1: chip soc/intel/alderlake
Sure Subrata... I have pushed patchset #13, to unblock External EC board bring up. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49871
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I997b89ba87fb03dfa6a836caec51efd05baa2e8d
Gerrit-Change-Number: 49871
Gerrit-PatchSet: 20
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-CC: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Attention: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Thu, 11 Feb 2021 09:58:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment