happycorsair@yandex.ru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48790 )
Change subject: superio/nuvoton/nct6793d: Add initial support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48790/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48790/1//COMMIT_MSG@11 PS1, Line 11: It's used in ASUS PRIME H310* motherboards (trying to make them run coreboot).
At least the Linux kernel seems to treat them the same in `drivers/hwmon/nct6775.c`.
Hi, Paul! I have access to NCT6791D (Date: January 8th, 2016 Revision 1.11) and NCT6793D (Date: June 29th, 2015 Revision 1.0) datasheets. One can find them in Internet, it's not a big deal.
Differences I've found so far: 1) NCT6793 supports four aux fans, NCT6791 supports only three (chapter 8.7). 2) NCT6793 has more LDNs (chapter 24). 3*) NCT6793 provides power fault handling (chapter 21). 4*) NCT6793 has HWM to port 80 feature (chapter 23). 5) NCT6793 has fading led feature (chapter 22). 6) Various small register differences.
Those with * are important, as for me.
That Linux driver deals only with hwmon features.
I don't like copy-paste, I think it's possible to try to make some shared part for various Nuvoton chips. But for now it's not a big problem, I think.
Anyway, I believe, that Kconfig options for NCT6793 and NCT6791 should be separated. Thanks!