Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/28396
Change subject: [Please test]nb/intel/i945/raminit: "Correct" DRTST ......................................................................
[Please test]nb/intel/i945/raminit: "Correct" DRTST
Tested on 945G-M4, it now boot even if channel 0 is not populated at all. Could you test if i945 laptop version will boot if DIMM0 is not populated?
Change-Id: I0d3229b842808d0920e25dcefe49eaceb8e10cdc Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/raminit.c 1 file changed, 1 insertion(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/28396/1
diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c index c259530..af741d5 100644 --- a/src/northbridge/intel/i945/raminit.c +++ b/src/northbridge/intel/i945/raminit.c @@ -1150,23 +1150,7 @@
asm volatile ("nop; nop;" ::: "memory");
- reg32 = MCHBAR32(DRTST); - - /* Is channel 0 populated? */ - if (sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED || - sysinfo->dimm[1] != SYSINFO_DIMM_NOT_POPULATED) - reg32 |= (1 << 7) | (1 << 5); - else - reg32 |= (1 << 31); - - /* Is channel 1 populated? */ - if (sysinfo->dimm[2] != SYSINFO_DIMM_NOT_POPULATED || - sysinfo->dimm[3] != SYSINFO_DIMM_NOT_POPULATED) - reg32 |= (1 << 9) | (1 << 8); - else - reg32 |= (1 << 30); - - MCHBAR32(DRTST) = reg32; + MCHBAR32(DRTST) |= (1 << 7) | (1 << 5);
/* Activate DRAM Channel IO Buffers */ if (sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED ||