Attention is currently required from: Hung-Te Lin, Mingjin Ge, Paul Menzel, Xuxin Xiong, Yang Wu, Yidi Lin, Yu-Ping Wu.
Wentao Qin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82089?usp=email )
Change subject: mb/google/corsola/wugtrio: Add initialization of USB port0
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/corsola/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/82089/comment/93e01f64_fb8a5b40 :
PS4, Line 4: USB2_PORT1
Revise the naming. […]
Done
File src/soc/mediatek/common/usb.c:
https://review.coreboot.org/c/coreboot/+/82089/comment/ebb24c84_ffd41e67 :
PS4, Line 15:
: #ifdef SOC_MEDIATEK_MT8186_USB_H
: void switch_usb_port0_host(void)
: {
: ippc_regs = (void *)(SSUSB_IPPC_BASE_P0);
: phy_ports = (void *)(SSUSB_SIF_BASE_P0);
: }
: #endif
:
Please consider the following approach. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82089?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I725b80593f5fc498a204bf47f943c36ccbd78134
Gerrit-Change-Number: 82089
Gerrit-PatchSet: 6
Gerrit-Owner: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Mingjin Ge
mingjin.ge@mediatek.corp-partner.google.com
Gerrit-Reviewer: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mingjin Ge
mingjin.ge@mediatek.corp-partner.google.com
Gerrit-Attention: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 29 Apr 2024 04:54:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Gerrit-MessageType: comment