Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39299 )
Change subject: mb/asus/p8z77-v_lx2: Add new mainboard ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... File src/mainboard/asus/p8z77-v_lx2/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... PS3, Line 18: */
This file was literally copied from here: https://github. […]
Copied another file instead
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... PS3, Line 20: Method(_PTS,1)
Add space before the comma?
Done
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... PS3, Line 26: Method(_WAK,1)
Ditot.
Done (I guess this was meant to say "Ditto" ?) 😄
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... File src/mainboard/asus/p8z77-v_lx2/early_init.c:
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... PS3, Line 48: /* Select SIO pin states. */
Ah, I see the inconsistency
Done
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... PS3, Line 57: /* Power RAM in S3. */
It’s not needed in a comment, and for consistency (see below).
Done