[coreboot-gerrit] New patch to review for coreboot: google/reef: Use exported GPIOs and ACPI regulator for touchscreen

[Furquan Shaikh]

Furquan Shaikh ([e-mail]) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17799

-gerrit

commit c6137bb8e251f2df9669d37fbd2b12c9146690ec
Author: Furquan Shaikh 
Date:   Mon Dec 12 09:34:55 2016 -0800

google/reef: Use exported GPIOs and ACPI regulator for touchscreen

ELAN touchscreen device expects firmware to export GPIOs and ACPI
    regulators for managing power to the device. Thus, provide the
    required ACPI elements for OS driver to properly manage this device.

BUG=chrome-os-partner:60194
    BRANCH=None
    TEST=Verified that touchscreen works properly on boot-up and after
    suspend/resume.

Change-Id: I298ca5de9c0ae302309d87e3dffb65f9be1e882e
    Signed-off-by: Furquan Shaikh 
---
 src/mainboard/google/reef/Kconfig                          | 3 +++
 src/mainboard/google/reef/variants/baseboard/devicetree.cb | 9 ++++++---
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig
index 2cc391e..afe449f 100644
--- a/src/mainboard/google/reef/Kconfig
+++ b/src/mainboard/google/reef/Kconfig
@@ -49,6 +49,9 @@ config DRIVERS_I2C_WACOM
 config DRIVERS_PS2_KEYBOARD
    default y

+config DRIVERS_REGULATOR_GPIO_REGULATOR
+	default y
+
 config MAINBOARD_DIR
    string
    default google/reef
diff --git a/src/mainboard/google/reef/variants/baseboard/devicetree.cb b/src/mainboard/google/reef/variants/baseboard/devicetree.cb
index a0b53d6..19efe77 100644
--- a/src/mainboard/google/reef/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/reef/variants/baseboard/devicetree.cb
@@ -179,11 +179,14 @@ chip soc/intel/apollolake
    			register "probed" = "1"
    			register "pwr_mgmt_type" = "GPIO_EXPORT"
    			register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)"
-				register "reset_delay_ms" = "20"
-				register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_152)"
-				register "enable_delay_ms" = "1"
    			device i2c 10 on end
    		end
+			chip drivers/regulator/gpio_regulator
+				register "name" = ""vcc33""
+				register "gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_152)"
+				register "enabled_on_boot" = "1"
+				device generic 0 on end
+			end
    	end	# - I2C 3
    	device pci 17.0 on
    		chip drivers/i2c/generic