Attention is currently required from: Shelley Chen, Venkat Thogaru, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66975 )
Change subject: qualcomm/sc7280: remove malloc allocation for tu and add early return for failure case ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/66975/comment/d1d8147a_f29ad42a PS2, Line 6:
Possible long commit subject (prefer a maximum 65 characters)
Please fix. How about `remove unnecessary malloc and early return on failure`
https://review.coreboot.org/c/coreboot/+/66975/comment/84f218b9_9d8ee5c9 PS2, Line 9: priniting printing
https://review.coreboot.org/c/coreboot/+/66975/comment/5522f700_63f3b5c8 PS2, Line 11: static It's not a static variable, just a local variable.
File src/soc/qualcomm/sc7280/display/edp_ctrl.c:
https://review.coreboot.org/c/coreboot/+/66975/comment/d71c0179_6492a7b4 PS2, Line 1225: tu_table Align with BIOS_INFO.