build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34382 )
Change subject: WIP: mediatek/mt8183: Add SCP work support ......................................................................
Patch Set 1:
(14 comments)
https://review.coreboot.org/c/coreboot/+/34382/1/src/soc/mediatek/mt8183/inc... File src/soc/mediatek/mt8183/include/soc/scp.h:
https://review.coreboot.org/c/coreboot/+/34382/1/src/soc/mediatek/mt8183/inc... PS1, Line 29: u32 reserved[11]; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34382/1/src/soc/mediatek/mt8183/inc... PS1, Line 29: u32 reserved[11]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34382/1/src/soc/mediatek/mt8183/inc... PS1, Line 30: u32 sram_pdn; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34382/1/src/soc/mediatek/mt8183/inc... PS1, Line 30: u32 sram_pdn; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34382/1/src/soc/mediatek/mt8183/scp... File src/soc/mediatek/mt8183/scp.c:
https://review.coreboot.org/c/coreboot/+/34382/1/src/soc/mediatek/mt8183/scp... PS1, Line 31: mb(); memory barrier without comment
https://review.coreboot.org/c/coreboot/+/34382/1/src/soc/mediatek/mt8183/scp... PS1, Line 45: memcpy((void *)SCP_SRAM_BASE + BUF_SIZE, scp_bin, fw_size); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34382/1/src/soc/mediatek/mt8183/scp... PS1, Line 45: memcpy((void *)SCP_SRAM_BASE + BUF_SIZE, scp_bin, fw_size); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34382/1/src/soc/mediatek/mt8183/scp... PS1, Line 55: memcpy((void *)SCP_SRAM_BASE + BUF_SIZE*2, scp_bin, fw_size); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34382/1/src/soc/mediatek/mt8183/scp... PS1, Line 55: memcpy((void *)SCP_SRAM_BASE + BUF_SIZE*2, scp_bin, fw_size); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34382/1/src/soc/mediatek/mt8183/scp... PS1, Line 62: while (read32(&mt8183_scp->gpr0) != 0xaaaa){} space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/34382/1/src/soc/mediatek/mt8183/scp... PS1, Line 62: while (read32(&mt8183_scp->gpr0) != 0xaaaa){} trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/34382/1/src/soc/mediatek/mt8183/scp... PS1, Line 62: while (read32(&mt8183_scp->gpr0) != 0xaaaa){} braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/34382/1/src/soc/mediatek/mt8183/scp... PS1, Line 63: mb(); memory barrier without comment
https://review.coreboot.org/c/coreboot/+/34382/1/src/soc/mediatek/mt8183/scp... PS1, Line 65: printk(BIOS_DEBUG, "scp finished \n"); unnecessary whitespace before a quoted newline