View Change

14 comments:

• File src/soc/mediatek/mt8183/include/soc/scp.h:

  • Patch Set #1, Line 29: u32 reserved[11];

    code indent should use tabs where possible

  • Patch Set #1, Line 29: u32 reserved[11];

    please, no spaces at the start of a line

  • Patch Set #1, Line 30: u32 sram_pdn;

    code indent should use tabs where possible

  • Patch Set #1, Line 30: u32 sram_pdn;

    please, no spaces at the start of a line

• File src/soc/mediatek/mt8183/scp.c:

  • Patch Set #1, Line 31: mb();

    memory barrier without comment

  • Patch Set #1, Line 45: memcpy((void *)SCP_SRAM_BASE + BUF_SIZE, scp_bin, fw_size);

    code indent should use tabs where possible

  • Patch Set #1, Line 45: memcpy((void *)SCP_SRAM_BASE + BUF_SIZE, scp_bin, fw_size);

    please, no spaces at the start of a line

  • Patch Set #1, Line 55: memcpy((void *)SCP_SRAM_BASE + BUF_SIZE*2, scp_bin, fw_size);

    code indent should use tabs where possible

  • Patch Set #1, Line 55: memcpy((void *)SCP_SRAM_BASE + BUF_SIZE*2, scp_bin, fw_size);

    please, no spaces at the start of a line

  • Patch Set #1, Line 62: while (read32(&mt8183_scp->gpr0) != 0xaaaa){}

    space required before the open brace '{'

  • Patch Set #1, Line 62: while (read32(&mt8183_scp->gpr0) != 0xaaaa){}

    trailing statements should be on next line

  • Patch Set #1, Line 62: while (read32(&mt8183_scp->gpr0) != 0xaaaa){}

    braces {} are not necessary for single statement blocks

  • Patch Set #1, Line 63: mb();

    memory barrier without comment

  • Patch Set #1, Line 65: printk(BIOS_DEBUG, "scp finished \n");

    unnecessary whitespace before a quoted newline

To view, visit change 34382. To unsubscribe, or for help writing mail filters, visit settings.