Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56325 )
Change subject: soc/intel/alderlake: Configure the SKU specific parameters for VR domains ......................................................................
Patch Set 1:
(5 comments)
File src/soc/intel/alderlake/include/soc/vr_config.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124265): https://review.coreboot.org/c/coreboot/+/56325/comment/778e8c8f_55b5583f PS1, Line 79: void fill_vr_domain_config(FSP_S_CONFIG *s_cfg, need consistent spacing around '*' (ctx:WxV)
File src/soc/intel/alderlake/vr_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124265): https://review.coreboot.org/c/coreboot/+/56325/comment/252b10ea_5d142197 PS1, Line 20: * | | GT | 3.2 | 3.2 | 50 | 57 | 28000 | please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124265): https://review.coreboot.org/c/coreboot/+/56325/comment/20331f13_e265d7c0 PS1, Line 24: * | | GT | 3.2 | 3.2 | 50 | 40 | 28000 | please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124265): https://review.coreboot.org/c/coreboot/+/56325/comment/4716cb2e_bc534a17 PS1, Line 28: * | | GT | 3.2 | 3.2 | 40 | 20 | 28000 | please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124265): https://review.coreboot.org/c/coreboot/+/56325/comment/02f23438_4541a210 PS1, Line 105: else { else should follow close brace '}'