Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44935 )
Change subject: soc/intel/baytrail: Add missing GSM size definitions
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44935/2/src/soc/intel/baytrail/incl...
File src/soc/intel/baytrail/include/soc/gfx.h:
https://review.coreboot.org/c/coreboot/+/44935/2/src/soc/intel/baytrail/incl...
PS2, Line 32: # define GGC_GSM_SIZE_480MB (15 << 3)
and `512MB (16 << 3)` at least that's what the BYT-T EDS says.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44935
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I456591f63f463c5cec1cbf3c1633bdb61be92d29
Gerrit-Change-Number: 44935
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Sep 2020 18:19:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment