Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43722 )
Change subject: nb/intel/x4x: Put host bridge registers into its own file
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43722/1/src/northbridge/intel/x4x/x...
File src/northbridge/intel/x4x/x4x.h:
https://review.coreboot.org/c/coreboot/+/43722/1/src/northbridge/intel/x4x/x...
PS1, Line 12: "hostbridge_regs.h"
include this in files actually using the macros?
I prefer indirectly including the register definitions. This is just to make the x4x.h header less cluttered.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43722
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c59099f6ff0e9162c700c888fb8fbb3906b65e6
Gerrit-Change-Number: 43722
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 01 Aug 2020 15:34:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment