Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32958 )
Change subject: commonlib: define cbtable tags as enum to identify conflicts ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32958/1/payloads/libpayload/include/coreboot... File payloads/libpayload/include/coreboot_tables.h:
https://review.coreboot.org/#/c/32958/1/payloads/libpayload/include/coreboot... PS1, Line 69: CB_TAG_SERIALNO = 0x002a, : CB_TAG_SPI_FLASH = 0x0029,
why are those 2 not in order?
oops. fixed
https://review.coreboot.org/#/c/32958/1/src/commonlib/include/commonlib/core... File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/#/c/32958/1/src/commonlib/include/commonlib/core... PS1, Line 80: LB_TAG_SERIALNO = 0x002a, : LB_TAG_SPI_FLASH = 0x0029
switch those two around?
Done