Attention is currently required from: Anil Kumar K, Jérémy Compostella, Paul Menzel, Angel Pons, Nick Vaccaro.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70796 )
Change subject: mb/google/brya: Define a more suitable MRC training text message
......................................................................
Patch Set 26: Code-Review+2
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/70796/comment/afc02759_dafbcd12
PS23, Line 335: config MEMORY_TRAINING_TEXT
Might be better to handle this in C code as an array of strings. […]
Agreed. There is another discussion on another CL with the same thought (cl:70300).
Since this is somewhat dupe and to keep the convo in one place, I will mark this one I created here resolved.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70796
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie71cd86746427789b3694d41224bf2c170af0f91
Gerrit-Change-Number: 70796
Gerrit-PatchSet: 26
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Tue, 03 Jan 2023 14:32:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tarun Tuli
taruntuli@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment