Mengqi Guo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31429 )
Change subject: mb/google/kahlee: Enable mode change as wake source for S3 ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31429/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31429/1//COMMIT_MSG@7 PS1, Line 7: /S0ix
The grunt boards don't support S0ix
Thanks for pointing it out!
https://review.coreboot.org/#/c/31429/1//COMMIT_MSG@7 PS1, Line 7: mb/google/kahlee/var/baseboard
mb/google/kahlee should be sufficient.
Done
https://review.coreboot.org/#/c/31429/1//COMMIT_MSG@10 PS1, Line 10:
Is there a bug for this? Why is this needed?
Attached bug number. This is for managing waking from touchpad.