Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38846 )
Change subject: soc/intel/cannonlake: Plumb TetonGlacierMode into dt
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38846/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/puff/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/38846/1/src/mainboard/google/hatch/...
PS1, Line 6: TetonGlacierMode
This doesn't exist in chip config.
wrong patch set version...
https://review.coreboot.org/c/coreboot/+/38846/1/src/mainboard/google/hatch/...
PS1, Line 7:
I believe you also need to set PcieRpEnable for RP11.
ditto.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38846
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9a72161494db6a4da4abd3302b06df7c70634ab
Gerrit-Change-Number: 38846
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: David Jimenez
dvjimenez@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 21 Feb 2020 07:50:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment