Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45041 )
Change subject: soc/intel/xeon_sp: Select CPU_INTEL_COMMON ......................................................................
Patch Set 2:
So I gave this a quick test. Added a function call to set_vmx_and_lock in cpx_init_cpus() and turned on CPU_INTEL_COMMON in Kconfig along with the other SMM features I've been testing:
select CPU_INTEL_COMMON_SMM select SOC_INTEL_COMMON_BLOCK_SMM select SOC_INTEL_COMMON_BLOCK_PMC select ACPI_INTEL_HARDWARE_SLEEP_VALUES select SMM_TSEG select HAVE_SMI_HANDLER select X86_SMM_LOADER_VERSION2 select REG_SCRIPT
And the Coreboot log shows this (I added some print debug messages)
set_vmx_and_lock enter set_feature_ctrl_vmx enter VMX status: enabled set_feature_ctrl_lock enter IA32_FEATURE_CONTROL status: locked set_vmx_and_lock exit