Attention is currently required from: Raul Rangel, Paul Menzel, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54871 )
Change subject: amdfwtool: Set the region_type as 0 for entry "BIOS level 2"
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54871/comment/40bdd473_c2e81317
PS2, Line 9: But we need to set it explicitly as
: a known value.
Why? According to some specification? Please document that.
It should be set as something, FF or 0. Both seem to be OK. It means nothing in the type 40h entry(pointer to L2).
It really is not in any documents.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54871
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b914f9f02beecce707aba86248826cd9208e6c0
Gerrit-Change-Number: 54871
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Thu, 27 May 2021 07:00:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment