Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32035 )
Change subject: nb/intel/sandybridge: Move southbridge code to bd82x6x ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
https://review.coreboot.org/#/c/32035/2/src/southbridge/intel/bd82x6x/early_... File src/southbridge/intel/bd82x6x/early_pch.c:
https://review.coreboot.org/#/c/32035/2/src/southbridge/intel/bd82x6x/early_... PS2, Line 383: | spaces around |
https://review.coreboot.org/#/c/32035/2/src/southbridge/intel/bd82x6x/early_... PS2, Line 391: printk(BIOS_DEBUG, "Disabling Watchdog reboot..."); It's done before console_init() now.
https://review.coreboot.org/#/c/32035/2/src/southbridge/intel/bd82x6x/early_... PS2, Line 394: printk(BIOS_DEBUG, " done.\n"); ...