Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43760 )
Change subject: mb/clevo/kbl-u: Add Clevo N240BU as variant ......................................................................
Patch Set 29:
(5 comments)
Patch Set 28:
My changes: ...
- Commented out panel configuration, since I have no idea how the new API works yet
didn't change much; it's a struct now, but the names are mostly the same. check cml-u
https://review.coreboot.org/c/coreboot/+/43760/29//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43760/29//COMMIT_MSG@12 PS29, Line 12: but will be mapped to the correct ID "... in soc code." I guess
https://review.coreboot.org/c/coreboot/+/43760/29//COMMIT_MSG@20 PS29, Line 20: Using GOP what about libgfxinit?
https://review.coreboot.org/c/coreboot/+/43760/29//COMMIT_MSG@30 PS29, Line 30: 3. With PcieRpClkReqSupport enabled the Wireless device does not show up. uhm, didn't we investigate and solve that? I don't remember
https://review.coreboot.org/c/coreboot/+/43760/29/src/mainboard/clevo/kbl-u/... File src/mainboard/clevo/kbl-u/variants/n240bu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43760/29/src/mainboard/clevo/kbl-u/... PS29, Line 37: "GMA_STATIC_DISPLAYS(0)" use the new GMA_DEFAULT_PANEL(0)
https://review.coreboot.org/c/coreboot/+/43760/29/src/mainboard/clevo/kbl-u/... PS29, Line 38: u_pp_up_delay_ms" = "200" # T3 : # register "gpu_pp_down_delay_ms" = " 0" # T10 : # register "gpu_pp_cycle_delay_ms" = "500" # T12 : # register "gpu_pp_backlight_on_delay_ms" = " 50" # T7 : # register "gpu_pp_backlight_off_delay_ms" = " 0" # T9 : # register "gpu_pch_backlight_pwm_hz" = "200" convert this to the new format; see cml-u