Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45798 )
Change subject: soc/intel/xeon_sp/cpx: Add save_dimm_info for SMBIOS type 17 ......................................................................
Patch Set 4:
(1 comment)
Patch Set 4:
Isn't that the same as in other SoCs? Can we move this to common code?
https://review.coreboot.org/c/coreboot/+/45798/4/src/soc/intel/xeon_sp/cpx/r... File src/soc/intel/xeon_sp/cpx/romstage.c:
https://review.coreboot.org/c/coreboot/+/45798/4/src/soc/intel/xeon_sp/cpx/r... PS4, Line 41: save_dimm_info that's a candidate for soc/intel/common, isn't it?