Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39237 )
Change subject: mb/google/dedede: Add SD card support ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39237/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39237/2/src/mainboard/google/dedede... PS2, Line 284: SD_CD_ODL */ This is the pin name as in the schematics. Please keep it that way to avoid confusion in the future.
https://review.coreboot.org/c/coreboot/+/39237/2/src/mainboard/google/dedede... PS2, Line 288: /* G7 : SD_SDIO_WP */ : PAD_NC(GPP_G7, NONE), Please leave it as NC and donot remove it.