Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38716 )
Change subject: mb/google/octopus: Override VBT selection for Bloog ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38716/6/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/bloog/variant.c:
https://review.coreboot.org/c/coreboot/+/38716/6/src/mainboard/google/octopu... PS6, Line 69:
Nit: Align this line with the sku_id in the previous line. That way return "vbt. […]
Done
https://review.coreboot.org/c/coreboot/+/38716/7/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/bloog/variant.c:
https://review.coreboot.org/c/coreboot/+/38716/7/src/mainboard/google/octopu... PS7, Line 68: if (sku_id == SKU_33_BLOOG || sku_id == SKU_34_BLOOG ||
suspect code indent for conditional statements (8, 12)
Done
https://review.coreboot.org/c/coreboot/+/38716/7/src/mainboard/google/octopu... PS7, Line 71: return "vbt.bin";
Statements should start on a tabstop
Done