Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35799 )
Change subject: soc/intel/sgx: make SGX a Kconfig option
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35799/2/src/soc/intel/apollolake/me...
File src/soc/intel/apollolake/memmap.c:
https://review.coreboot.org/c/coreboot/+/35799/2/src/soc/intel/apollolake/me...
PS2, Line 41: PrmrrSize
I find it weird that this is an FSP-M parameter, but sgx_enable isn't. So the prmrrSize region is set up by FSP-M but is just ram unless sgx is enabled?
I have no knowledge on either but this deserves an explanation in comments.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f08e85898304bba6680075ca5d6bce26aef9a4d
Gerrit-Change-Number: 35799
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 04 Oct 2019 16:18:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment