[coreboot-gerrit] [S] Change in coreboot[master]: soc/amd/mendocino: Add Kconfig option to generate manifest

[Martin L Roth (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Jakub Czapiga, Matt DeVillier, Paul Menzel, Grzegorz Bernacki, Fred Reitberger, Karthik Ramasubramanian, Felix Held.

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74267 )

Change subject: soc/amd/mendocino: Add Kconfig option to generate manifest
......................................................................

Patch Set 5:

(2 comments)

Patchset:

PS5: 
Why have a Kconfig option? Is there a reason not to just add this all the time?

If it does make sense to add a Kconfig file, why not default it to on?

Does it make sense to add this to other AMD platforms?  If it does, maybe add (most of) this to the common Kconfig and Makefile? Obviously the option needs to be added to each platform's makefile individually.

File src/soc/amd/mendocino/Kconfig:

https://review.coreboot.org/c/coreboot/+/74267/comment/c821474a_35fa09be 
PS5, Line 487: INCLUDE_MANIFEST_FILE
Can this be more specific?  STORE_AMDFW_MANIFEST maybe?